diff --git a/nemu/src/utils/elf-parser.c b/nemu/src/utils/elf-parser.c index 8ea582b..25be7fc 100644 --- a/nemu/src/utils/elf-parser.c +++ b/nemu/src/utils/elf-parser.c @@ -12,9 +12,9 @@ void init_elf(const char *path) { FILE *elf_file = fopen(path, "rb"); Elf32_Ehdr header; Elf32_Shdr section_header, *psh; - FAILED_GOTO(failed_nosym, fread(&header, sizeof(Elf32_Ehdr), 1, elf_file) > 0); + FAILED_GOTO(failed_nosym, fread(&header, sizeof(Elf32_Ehdr), 1, elf_file) <= 0); FAILED_GOTO(failed_nosym, fseek(elf_file, header.e_shoff, SEEK_SET) != 0); - FAILED_GOTO(failed_nosym, fread(§ion_header, header.e_shentsize, header.e_shnum, elf_file) > 0); + FAILED_GOTO(failed_nosym, fread(§ion_header, header.e_shentsize, header.e_shnum, elf_file) <= 0); Elf32_Shdr *symtab = NULL, *strtab = NULL; for(int i = 0; i < header.e_shnum; i++) { @@ -30,13 +30,13 @@ void init_elf(const char *path) { int sym_length = symtab->sh_entsize / sizeof(Elf32_Sym); Elf32_Sym *sym = calloc(sym_length, sizeof(Elf32_Sym)); FAILED_GOTO(failed, fseek(elf_file, symtab->sh_offset, SEEK_SET) != 0); - FAILED_GOTO(failed, fread(&sym, sizeof(Elf32_Sym), sym_length, elf_file) > 0); + FAILED_GOTO(failed, fread(&sym, sizeof(Elf32_Sym), sym_length, elf_file) <= 0); for(int j = 0; j < sym_length; j++) { if(ELF32_ST_TYPE(sym[j].st_info) != STT_FUNC) continue; // Only read function type symbol char func[30] = ""; FAILED_GOTO(failed, fseek(elf_file, sym[j].st_name + strtab->sh_offset, SEEK_SET) != 0); - FAILED_GOTO(failed, fgets(func, 30, elf_file) > 0); + FAILED_GOTO(failed, fgets(func, 30, elf_file) <= 0); puts(func); } return;