Commit graph

9 commits

Author SHA1 Message Date
Nick Novitski
a2060d116a Don't --ignore-environment
This leads to some surprising behavior, and I don't think it gives the benefits I thought it would.
2023-11-07 20:40:01 -08:00
Nick Novitski
9342b170fb fix: Runs on MacOS runners 2023-10-19 17:49:28 -07:00
Nick Novitski
2cd3e161f5 fix: Fail if build fails!
The pipefail option does not catch usage from subshells like this:

```
echo <<<"$(echo foo; exit 1)"
```

Since that's how `nix develop` is called in the script, when the action
could not build an environment, it would still be treated as having run
successfully, and the job would continue.

It's still hypothetically possible for this to happen if `env` or `bash
-c 'echo $PATH'` fail.  Seems unlikely!  But maybe there's something to
be done there.
2023-10-19 10:15:04 -07:00
Nick Novitski
f33559582d fix: Pass arguments
The INPUTS_* environment variables are not present in composite actions.
A flag interface seems more intuitive for local testing too.
2023-10-19 10:13:44 -07:00
Nick Novitski
c6e9a101ae feat: Don't add nonexistent directories to PATH 2023-10-18 22:11:13 -07:00
Nick Novitski
a30a7fa1b3 feat: Don't add empty or already-set variables 2023-10-18 22:09:38 -07:00
Nick Novitski
645aeb5651 feat: detect and fail on invalid delimiters 2023-10-18 20:52:41 -07:00
Nick Novitski
fa86b00e2a fix: support --keep flag in arguments
Achieved by consistently using `--ignore-environment` flag, even though
that's not strictly necessary.

Fixes using devenv, which requires `--keep PATH` to run its shellhook.
2023-10-18 20:37:01 -07:00
Nick Novitski
e10b9cffe9 Initial commit 2023-10-18 16:57:10 -07:00